Skip to content

The derived properties are included to the data schema. - #442

Open
zeynepatsoprasteria wants to merge 1 commit into
developmentfrom
429-mergeasync-sends-resolution-elements-without-the-derived-properties-the-data-schema-requires
Open

zeynepatsoprasteria wants to merge 1 commit into
developmentfrom
429-mergeasync-sends-resolution-elements-without-the-derived-properties-the-data-schema-requires

Conversation

@zeynepatsoprasteria

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the SysML2.NET code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #429 the derived properties is now included into resolution elements send by MergeAsync.

@sonarqubecloud

Copy link
Copy Markdown

@antoineatsoprasteria

Copy link
Copy Markdown
Collaborator

I propose to not merge it since we shall be able to ignore derived properties (#429 (comment))

@samatstariongroup samatstariongroup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally at a8931bf: build clean, full test suite green. The merge endpoint is the only request body typed as an array of Data in the OpenAPI document, and the changed overload has a single caller (MergeAsync), so commit payloads are unaffected. The new assertions fail on the previous code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MergeAsync sends resolution elements without the derived properties the Data schema requires

3 participants